[webkit-changes] [WebKit/WebKit] ecdb7e: [iOS][visionOS] web.webex.com: Icons inside some b...

Tim Nguyen noreply at github.com
Fri Jan 24 06:02:42 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecdb7e0d240e9c71f87d407d37988a8fe3bb7a97
      https://github.com/WebKit/WebKit/commit/ecdb7e0d240e9c71f87d407d37988a8fe3bb7a97
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M LayoutTests/interaction-region/button-in-link-expected.txt
    M LayoutTests/platform/ios/css2.1/20110323/replaced-elements-001-expected.txt
    M LayoutTests/platform/ios/fast/forms/001-expected.txt
    M LayoutTests/platform/ios/fast/forms/button-default-title-expected.txt
    M LayoutTests/platform/ios/fast/forms/button-style-color-expected.txt
    M LayoutTests/platform/ios/fast/forms/input-first-letter-expected.txt
    M LayoutTests/platform/ios/fast/forms/select-baseline-expected.txt
    M Source/WebCore/css/html.css

  Log Message:
  -----------
  [iOS][visionOS] web.webex.com: Icons inside some buttons can be too small
https://bugs.webkit.org/show_bug.cgi?id=286447
rdar://138155959

Reviewed by Aditya Keerthi.

The default inline button padding on iOS is too large and squashes the SVG within the button.
`RenderThemeIOS::adjustButtonStyle` already sets this larger padding for `appearance: auto`.

For `appearance: none`, we can just re-use the default desktop inline padding of 6px, to be compatible and interoperable with other browsers.

* LayoutTests/interaction-region/button-in-link-expected.txt:
* LayoutTests/platform/ios/css2.1/20110323/replaced-elements-001-expected.txt:
* LayoutTests/platform/ios/fast/forms/001-expected.txt:
* LayoutTests/platform/ios/fast/forms/button-default-title-expected.txt:
* LayoutTests/platform/ios/fast/forms/button-style-color-expected.txt:
* LayoutTests/platform/ios/fast/forms/input-first-letter-expected.txt:
* LayoutTests/platform/ios/fast/forms/select-baseline-expected.txt:
* Source/WebCore/css/html.css:
(input:is([type="button"], [type="submit"], [type="reset"]), input[type="file"]::file-selector-button, button):

Canonical link: https://commits.webkit.org/289343@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list