[webkit-changes] [WebKit/WebKit] 26f8bc: Fix device type used by `run-minibrowser --ipad-si...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26f8bc833e26d5b72c2a14f69db46ecbbda7e0ef
      https://github.com/WebKit/WebKit/commit/26f8bc833e26d5b72c2a14f69db46ecbbda7e0ef
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Tools/Scripts/webkitdirs.pm
    M Tools/Scripts/webkitpy/port/ios_simulator.py

  Log Message:
  -----------
  Fix device type used by `run-minibrowser --ipad-simulator`
https://bugs.webkit.org/show_bug.cgi?id=286441
rdar://143523453

Reviewed by Jonathan Bedard.

Previously we got an "incompatible device" error because the iPad Pro
(9.7-inch) does not support iOS 17 or later, hence the simctl
invocation fails.

This makes us use the same device type between webkitpy and
webkitdirs.pm; developers likely want to use the same device type as
our tests use by default.

* Tools/Scripts/webkitdirs.pm:
(findOrCreateSimulatorForIOSDevice):
* Tools/Scripts/webkitpy/port/ios_simulator.py:
(IPhoneSimulatorPort):
(IPadSimulatorPort):

Canonical link: https://commits.webkit.org/289336@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications