[webkit-changes] [WebKit/WebKit] 62424a: Web Inspector: Increase adoption of smart pointers

Claudio Saavedra noreply at github.com
Thu Jan 23 22:09:54 PST 2025 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62424a3a679b41b7e40cea7b20380a16760b12a4
      https://github.com/WebKit/WebKit/commit/62424a3a679b41b7e40cea7b20380a16760b12a4
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2025-01-23 (Thu, 23 Jan 2025)

  Changed paths:
    M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WebCore/inspector/DOMPatchSupport.cpp
    M Source/WebCore/inspector/DOMPatchSupport.h
    M Source/WebCore/inspector/InspectorWebAgentBase.h
    M Source/WebCore/inspector/PageDebugger.cpp
    M Source/WebCore/inspector/PageDebugger.h
    M Source/WebCore/inspector/WorkerDebugger.cpp
    M Source/WebCore/inspector/WorkerDebugger.h
    M Source/WebCore/inspector/WorkerInspectorController.cpp
    M Source/WebCore/inspector/WorkerInspectorController.h
    M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
    M Source/WebCore/inspector/agents/InspectorAnimationAgent.h
    M Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.cpp
    M Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.h
    M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
    M Source/WebCore/inspector/agents/InspectorCSSAgent.h
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.h
    M Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp
    M Source/WebCore/inspector/agents/InspectorDOMStorageAgent.h
    M Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp
    M Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h
    M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
    M Source/WebCore/inspector/agents/InspectorPageAgent.h
    M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp
    M Source/WebCore/inspector/agents/InspectorTimelineAgent.h
    M Source/WebCore/inspector/agents/page/PageAuditAgent.cpp
    M Source/WebCore/inspector/agents/page/PageAuditAgent.h
    M Source/WebCore/inspector/agents/page/PageCanvasAgent.cpp
    M Source/WebCore/inspector/agents/page/PageCanvasAgent.h
    M Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp
    M Source/WebCore/inspector/agents/page/PageConsoleAgent.h
    M Source/WebCore/inspector/agents/page/PageDebuggerAgent.cpp
    M Source/WebCore/inspector/agents/page/PageDebuggerAgent.h
    M Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp
    M Source/WebCore/inspector/agents/page/PageNetworkAgent.h
    M Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp
    M Source/WebCore/inspector/agents/page/PageRuntimeAgent.h
    M Source/WebCore/inspector/agents/page/PageWorkerAgent.cpp
    M Source/WebCore/inspector/agents/page/PageWorkerAgent.h
    M Source/WebCore/inspector/agents/worker/ServiceWorkerAgent.cpp
    M Source/WebCore/inspector/agents/worker/ServiceWorkerAgent.h
    M Source/WebCore/inspector/agents/worker/WorkerAuditAgent.cpp
    M Source/WebCore/inspector/agents/worker/WorkerCanvasAgent.cpp
    M Source/WebCore/inspector/agents/worker/WorkerConsoleAgent.cpp
    M Source/WebCore/inspector/agents/worker/WorkerDebuggerAgent.cpp
    M Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.cpp
    M Source/WebCore/inspector/agents/worker/WorkerRuntimeAgent.cpp
    M Source/WebCore/inspector/agents/worker/WorkerWorkerAgent.cpp

  Log Message:
  -----------
  Web Inspector: Increase adoption of smart pointers
https://bugs.webkit.org/show_bug.cgi?id=286143

Reviewed by Devin Rousso.

Drop usage of raw pointers and references as class and
struct members in many places, in favor of smart
pointers. This fixes many clang static analyzer
warnings.

* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
* Source/WebCore/inspector/DOMPatchSupport.h:
* Source/WebCore/inspector/InspectorWebAgentBase.h:
* Source/WebCore/inspector/PageDebugger.cpp:
(WebCore::PageDebugger::attachDebugger):
(WebCore::PageDebugger::detachDebugger):
(WebCore::PageDebugger::didPause):
(WebCore::PageDebugger::didContinue):
(WebCore::PageDebugger::runEventLoopWhilePausedInternal):
* Source/WebCore/inspector/PageDebugger.h:
* Source/WebCore/inspector/WorkerDebugger.cpp:
(WebCore::WorkerDebugger::attachDebugger):
(WebCore::WorkerDebugger::detachDebugger):
(WebCore::WorkerDebugger::runEventLoopWhilePaused):
* Source/WebCore/inspector/WorkerDebugger.h:
* Source/WebCore/inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::updateServiceWorkerPageFrontendCount):
(WebCore::WorkerInspectorController::vm):
* Source/WebCore/inspector/WorkerInspectorController.h:
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::enable):
* Source/WebCore/inspector/agents/InspectorAnimationAgent.h:
* Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
* Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.h:
* Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
* Source/WebCore/inspector/agents/InspectorCSSAgent.h:
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::setSearchingForNode):
* Source/WebCore/inspector/agents/InspectorDOMAgent.h:
* Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::findStorageArea):
* Source/WebCore/inspector/agents/InspectorDOMStorageAgent.h:
* Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:
* Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::navigate):
(WebCore::InspectorPageAgent::overrideSetting):
(WebCore::InspectorPageAgent::overridePrefersReducedMotion):
(WebCore::InspectorPageAgent::overridePrefersContrast):
(WebCore::InspectorPageAgent::overridePrefersColorScheme):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::setCookie):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::defaultUserPreferencesDidChange):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::snapshotNode):
(WebCore::InspectorPageAgent::snapshotRect):
(WebCore::InspectorPageAgent::archive):
(WebCore::InspectorPageAgent::setScreenSizeOverride):
* Source/WebCore/inspector/agents/InspectorPageAgent.h:
* Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::captureScreenshot):
* Source/WebCore/inspector/agents/InspectorTimelineAgent.h:
* Source/WebCore/inspector/agents/page/PageAuditAgent.cpp:
(WebCore::PageAuditAgent::injectedScriptForEval):
* Source/WebCore/inspector/agents/page/PageAuditAgent.h:
* Source/WebCore/inspector/agents/page/PageCanvasAgent.cpp:
(WebCore::PageCanvasAgent::matchesCurrentContext const):
* Source/WebCore/inspector/agents/page/PageCanvasAgent.h:
* Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::setLoggingChannelLevel):
* Source/WebCore/inspector/agents/page/PageConsoleAgent.h:
* Source/WebCore/inspector/agents/page/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
(WebCore::PageDebuggerAgent::breakpointActionLog):
(WebCore::PageDebuggerAgent::injectedScriptForEval):
* Source/WebCore/inspector/agents/page/PageDebuggerAgent.h:
* Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp:
(WebCore::PageNetworkAgent::setResourceCachingDisabledInternal):
(WebCore::PageNetworkAgent::addConsoleMessage):
* Source/WebCore/inspector/agents/page/PageNetworkAgent.h:
* Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::injectedScriptForEval):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
* Source/WebCore/inspector/agents/page/PageRuntimeAgent.h:
* Source/WebCore/inspector/agents/page/PageWorkerAgent.cpp:
(WebCore::PageWorkerAgent::connectToAllWorkerInspectorProxies):
* Source/WebCore/inspector/agents/page/PageWorkerAgent.h:
* Source/WebCore/inspector/agents/worker/ServiceWorkerAgent.cpp:
(WebCore::ServiceWorkerAgent::ServiceWorkerAgent):
(WebCore::ServiceWorkerAgent::getInitializationInfo):
* Source/WebCore/inspector/agents/worker/ServiceWorkerAgent.h:
* Source/WebCore/inspector/agents/worker/WorkerAuditAgent.cpp:
(WebCore::WorkerAuditAgent::WorkerAuditAgent):
* Source/WebCore/inspector/agents/worker/WorkerCanvasAgent.cpp:
(WebCore::WorkerCanvasAgent::WorkerCanvasAgent):
* Source/WebCore/inspector/agents/worker/WorkerConsoleAgent.cpp:
(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
* Source/WebCore/inspector/agents/worker/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
* Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.cpp:
(WebCore::WorkerNetworkAgent::WorkerNetworkAgent):
* Source/WebCore/inspector/agents/worker/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
* Source/WebCore/inspector/agents/worker/WorkerWorkerAgent.cpp:
(WebCore::WorkerWorkerAgent::WorkerWorkerAgent):

Canonical link: https://commits.webkit.org/289330@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list