[webkit-changes] [WebKit/WebKit] af35d7: [JSC] DFG BasicBlock should be unique_ptr

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af35d7a427a10e85b8c729e4ddbb7c412cefaafb
      https://github.com/WebKit/WebKit/commit/af35d7a427a10e85b8c729e4ddbb7c412cefaafb
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2025-01-23 (Thu, 23 Jan 2025)

  Changed paths:
    M Source/JavaScriptCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/JavaScriptCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/JavaScriptCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
    M Source/JavaScriptCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/JavaScriptCore/dfg/DFGBasicBlock.h
    M Source/JavaScriptCore/dfg/DFGBlockInsertionSet.cpp
    M Source/JavaScriptCore/dfg/DFGBlockInsertionSet.h
    M Source/JavaScriptCore/dfg/DFGBlockWorklist.h
    M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
    M Source/JavaScriptCore/dfg/DFGGraph.h
    M Source/JavaScriptCore/dfg/DFGLoopPreHeaderCreationPhase.h
    M Source/JavaScriptCore/dfg/DFGNode.h
    M Source/JavaScriptCore/dfg/DFGOSRExit.h
    M Source/JavaScriptCore/dfg/DFGOSRExitBase.h

  Log Message:
  -----------
  [JSC] DFG BasicBlock should be unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=286410
rdar://143458637

Reviewed by Yijia Huang and Keith Miller.

There is zero reason it is RefCounted. To make ownership model explicit,
let's use std::unique_ptr.

* Source/JavaScriptCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/JavaScriptCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/JavaScriptCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/JavaScriptCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/JavaScriptCore/dfg/DFGBasicBlock.h:
* Source/JavaScriptCore/dfg/DFGBlockInsertionSet.cpp:
(JSC::DFG::BlockInsertionSet::insert):
(JSC::DFG::BlockInsertionSet::execute):
* Source/JavaScriptCore/dfg/DFGBlockInsertionSet.h:
* Source/JavaScriptCore/dfg/DFGBlockWorklist.h:
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::allocateTargetableBlock):
(JSC::DFG::ByteCodeParser::allocateUntargetableBlock):
(JSC::DFG::ByteCodeParser::handleInlining):
* Source/JavaScriptCore/dfg/DFGGraph.h:
* Source/JavaScriptCore/dfg/DFGLoopPreHeaderCreationPhase.h:
* Source/JavaScriptCore/dfg/DFGNode.h:
* Source/JavaScriptCore/dfg/DFGOSRExit.h:
* Source/JavaScriptCore/dfg/DFGOSRExitBase.h:

Canonical link: https://commits.webkit.org/289313@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications