[webkit-changes] [WebKit/WebKit] 43470d: [Cleanup] Remove RenderStyle::whiteSpace().

[Yulun Wu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43470dbb41a950390f2d0a7cddcc038c83bf3652
      https://github.com/WebKit/WebKit/commit/43470dbb41a950390f2d0a7cddcc038c83bf3652
  Author: Yulun Wu <yulun_wu at apple.com>
  Date:   2025-01-23 (Thu, 23 Jan 2025)

  Changed paths:
    M Source/WebCore/editing/cocoa/HTMLConverter.mm
    M Source/WebCore/rendering/line/LineInlineHeaders.h
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h

  Log Message:
  -----------
  [Cleanup] Remove RenderStyle::whiteSpace().
https://bugs.webkit.org/show_bug.cgi?id=286084
<rdar://143067379>

Reviewed by Alan Baradlay.

The whiteSpace() shorthand does not represent all combinations of the
longhands textWrapMode() and whiteSpaceCollapse(). whiteSpace() handles
unsupported cases by misclassifying them as WhiteSpace::Normal.

This misclassification and has caused undefinied behavior in the past:

rdar://141021052

This PR removes usage of whiteSpace() in WebCore and
replaces calls to WhiteSpace() with the corresponding
longhand textWrapMode() and whiteSpaceCollapse.

Canonical link: https://commits.webkit.org/289303@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications