[webkit-changes] [WebKit/WebKit] 131e51: Fix crash in AccessibilityUIElement::textMarkerRan...

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 131e516e4f9907dc2bdfff649a1959a0716265fe
      https://github.com/WebKit/WebKit/commit/131e516e4f9907dc2bdfff649a1959a0716265fe
  Author: Frédéric Wang <fwang at igalia.com>
  Date:   2025-01-23 (Thu, 23 Jan 2025)

  Changed paths:
    A LayoutTests/accessibility/text-marker-range-for-element-crash-expected.txt
    A LayoutTests/accessibility/text-marker-range-for-element-crash.html
    M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
    M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  Fix crash in AccessibilityUIElement::textMarkerRangeForElement()
https://bugs.webkit.org/show_bug.cgi?id=286015

Reviewed by Darin Adler.

It receives a null element pointer when argument count is zero, so the
different platforms and test runners must check that case.

* LayoutTests/accessibility/text-marker-range-for-element-crash-expected.txt: Added.
* LayoutTests/accessibility/text-marker-range-for-element-crash.html: Added.
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::textMarkerRangeForElement): null-check element.
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::textMarkerRangeForElement): Ditto.
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.

Canonical link: https://commits.webkit.org/289295@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications