[webkit-changes] [WebKit/WebKit] 8c16d1: [PassKeys] Make the search filter for PassKeys mor...

nmahendru noreply at github.com
Thu Jan 23 08:39:08 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c16d17d9bf3bcdf3414da111498366bb0e700c1
      https://github.com/WebKit/WebKit/commit/8c16d17d9bf3bcdf3414da111498366bb0e700c1
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2025-01-23 (Thu, 23 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm

  Log Message:
  -----------
  [PassKeys] Make the search filter for PassKeys more broad.
https://bugs.webkit.org/show_bug.cgi?id=286372
rdar://143411897

Reviewed by Pascoe.

It is possible that some private keys are actually marked wrongly as public
and thus are not showing up in search. This will let them show up.

It's not the best but should hopefully return what was being returned earlier.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(getAllLocalAuthenticatorCredentialsImpl):
(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):
(+[_WKWebAuthenticationPanel exportLocalAuthenticatorCredentialWithGroupAndID:credential:error:]):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::processLargeBlobExtension):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
(WebKit::LocalConnection::getExistingCredentials):

Canonical link: https://commits.webkit.org/289294@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list