[webkit-changes] [WebKit/WebKit] 038288: Remove wheel event handling of <input type="number">

Anne van Kesteren noreply at github.com
Thu Jan 23 05:51:26 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03828826a1c32957530ce0e352af2859a307fa49
      https://github.com/WebKit/WebKit/commit/03828826a1c32957530ce0e352af2859a307fa49
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2025-01-23 (Thu, 23 Jan 2025)

  Changed paths:
    R LayoutTests/fast/forms/number/number-wheel-event-expected.txt
    R LayoutTests/fast/forms/number/number-wheel-event.html
    R LayoutTests/fast/forms/resources/common-wheel-event.js
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebCore/html/TextFieldInputType.h
    M Source/WebCore/html/shadow/SpinButtonElement.cpp
    M Source/WebCore/html/shadow/SpinButtonElement.h

  Log Message:
  -----------
  Remove wheel event handling of <input type="number">
https://bugs.webkit.org/show_bug.cgi?id=244240
rdar://99318505

Reviewed by Simon Fraser.

This behavior does not match Apple platform behavior and is confusing
to end users. Web developers also frequently seek to disable it or
inadvertently enable it.

* LayoutTests/fast/forms/number/number-wheel-event-expected.txt: Removed.
* LayoutTests/fast/forms/number/number-wheel-event.html: Removed.
* LayoutTests/fast/forms/resources/common-wheel-event.js: Removed.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents const): Deleted.
* Source/WebCore/html/TextFieldInputType.h:
* Source/WebCore/html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::forwardEvent): Deleted.
* Source/WebCore/html/shadow/SpinButtonElement.h:

Canonical link: https://commits.webkit.org/289285@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list