[webkit-changes] [WebKit/WebKit] 384d44: Flatten colorInputStyleSheet into html.css

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 384d445acb33202e02a6e5d74d9e3b8371d709e9
      https://github.com/WebKit/WebKit/commit/384d445acb33202e02a6e5d74d9e3b8371d709e9
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2025-01-22 (Wed, 22 Jan 2025)

  Changed paths:
    R LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt
    M Source/WebCore/css/html.css
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/ios/RenderThemeIOS.h
    M Source/WebCore/rendering/ios/RenderThemeIOS.mm
    M Source/WebCore/style/InspectorCSSOMWrappers.cpp
    M Source/WebCore/style/UserAgentStyle.cpp
    M Source/WebCore/style/UserAgentStyle.h

  Log Message:
  -----------
  Flatten colorInputStyleSheet into html.css
https://bugs.webkit.org/show_bug.cgi?id=286344

Reviewed by Sam Weinig.

html.css already contained some <input type=color> styles. Might as
well contain all of them for clarity and ease of ongoing maintenance.

While we are in UserAgentStyle we move all the rules that implicitly
are conditional upon is<HTMLElement> into that branch and remove some
redundant comments.

This ends up applying a couple more styles to <input type=color> in
WK1, but that reduction in differences seems acceptable, if not
worthwhile.

* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* Source/WebCore/css/html.css:
(#endif):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::colorInputStyleSheet const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
* Source/WebCore/rendering/ios/RenderThemeIOS.h:
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::colorInputStyleSheet const): Deleted.
* Source/WebCore/style/InspectorCSSOMWrappers.cpp:
(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers):
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::initDefaultStyleSheet):
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
* Source/WebCore/style/UserAgentStyle.h:

Canonical link: https://commits.webkit.org/289278@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications