[webkit-changes] [WebKit/WebKit] f5c8c8: Resolve the showNotification promise when service ...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5c8c88d3ce6a43e8d1008c4e856a2383b49f038
      https://github.com/WebKit/WebKit/commit/f5c8c88d3ce6a43e8d1008c4e856a2383b49f038
  Author: Brady Eidson <beidson at apple.com>
  Date:   2025-01-22 (Wed, 22 Jan 2025)

  Changed paths:
    M Source/WebCore/workers/service/ServiceWorkerRegistration.cpp

  Log Message:
  -----------
  Resolve the showNotification promise when service workers change a mutable declarative web push notification
rdar://143448984
https://bugs.webkit.org/show_bug.cgi?id=286402

Reviewed by Ben Nham.

This missing promise resolve caused a few weird behaviors that were much more obvious on iOS
which - sadly - doesn't have the webpushd API tests working yet.

I can't add a more useful test for this other than what WebPushDPushNotificationEventTest.Basic
already covers.

* Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::showNotification):

Canonical link: https://commits.webkit.org/289273@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications