[webkit-changes] [WebKit/WebKit] fb629b: Unable to scroll through Notes, Mail, and Photos o...

[lilyspiniolas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb629be740442d05db62a5f2fcb98e867500804a
      https://github.com/WebKit/WebKit/commit/fb629be740442d05db62a5f2fcb98e867500804a
  Author: Lily Spiniolas <lily_spiniolas at apple.com>
  Date:   2025-01-22 (Wed, 22 Jan 2025)

  Changed paths:
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/ios/EventHandlerIOS.mm
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm

  Log Message:
  -----------
  Unable to scroll through Notes, Mail, and Photos on iCloud.com using external mouse
https://bugs.webkit.org/show_bug.cgi?id=286200
rdar://136683606

Reviewed by Tim Horton and Abrar Rahman Protyasha.

Prior to these changes, iOS did not pass wheel events to subframes,
which resulted in scrolling not working on iCloud.com.
The WK2 codepath in 'EventHandler::passWheelEventToWidget' for iOS
now behaves the same as its Mac counterpart, resulting in wheel
events being dispatched to subframes appropriately. The function's
other definitions were also updated to use RefPtrs instead of
raw pointers in the WK2 codepath.

To test these changes, 'WheelEventDispatchedToSubframe'
was added to WKScrollViewTests. The test sets a global
variable, which is updated by a wheel event listener
set by the iframe. A scroll is performed on the web
view, and if the global variable gets updated,
the test passes.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::passWheelEventToWidget):
* Source/WebCore/page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::passWheelEventToWidget):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWheelEventToWidget):
* Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
(TEST(WKScrollViewTests, WheelEventDispatchedToSubframe)):

Canonical link: https://commits.webkit.org/289256@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications