[webkit-changes] [WebKit/WebKit] fc2320: Regression(289197 at main) Unable to pass relative te...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc23208c5f845f59216eccd0dc5202368a17999a
      https://github.com/WebKit/WebKit/commit/fc23208c5f845f59216eccd0dc5202368a17999a
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-01-22 (Wed, 22 Jan 2025)

  Changed paths:
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Regression(289197 at main) Unable to pass relative test paths to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=286362

Reviewed by Darin Adler.

In 289197 at main, I switched from using null terminated `const char*` to spans.
However, I got the size of the span wrong in the relative path case because
the allocated memory is larger than the resulting path (we use PATH_MAX).

We now keep track how the actual path length inside the malloc'd buffer and
use this for the span we pass to WKURLCreateWithUTF8String(). I also stop
storing a null terminator in the buffer since it is useless now that we
track the string size.

* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::createTestURL):

Canonical link: https://commits.webkit.org/289252@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications