[webkit-changes] [WebKit/WebKit] 66689c: Remove ENABLE_MODERN_MEDIA_CONTROLS directive

Anne van Kesteren noreply at github.com
Tue Jan 21 23:19:28 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66689c0533f661fc0c29c1885a354e4ae9a29b41
      https://github.com/WebKit/WebKit/commit/66689c0533f661fc0c29c1885a354e4ae9a29b41
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2025-01-21 (Tue, 21 Jan 2025)

  Changed paths:
    M Source/WTF/wtf/PlatformEnable.h
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
    M Source/WebCore/PlatformPlayStation.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    R Source/WebCore/css/mediaControls.css
    M Source/WebCore/dom/ImageOverlay.cpp
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/html/MediaDocument.cpp
    M Source/WebCore/html/MediaDocument.h
    M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
    M Source/WebCore/platform/Adwaita.cmake
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp
    M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h
    M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
    M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
    M Source/WebCore/style/InspectorCSSOMWrappers.cpp
    M Source/WebCore/style/UserAgentStyle.cpp
    M Source/WebCore/style/UserAgentStyle.h
    M Source/WebKit/PlatformGTK.cmake
    M Source/WebKit/PlatformWPE.cmake
    M Source/cmake/OptionsGTK.cmake
    M Source/cmake/OptionsWPE.cmake
    M Source/cmake/OptionsWin.cmake
    M Source/cmake/WebKitFeatures.cmake

  Log Message:
  -----------
  Remove ENABLE_MODERN_MEDIA_CONTROLS directive
https://bugs.webkit.org/show_bug.cgi?id=286289

Reviewed by Michael Catanzaro, Darin Adler, and Don Olmstead.

This feature has been part of WebKit for many years.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::supportsRewind const):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/mediaControls.css: Removed.
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateSubtree):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pauseAfterDetachedTask):
(WebCore::HTMLMediaElement::exitFullscreen):
(WebCore::HTMLMediaElement::setShowingStats):
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange): Deleted.
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::ancestorVideoElement): Deleted.
(WebCore::MediaDocument::defaultEventHandler): Deleted.
* Source/WebCore/html/MediaDocument.h:
* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsBackgroundCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextColor const):
* Source/WebCore/platform/Adwaita.cmake:
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsStyleSheet):
(WebCore::RenderTheme::mediaControlsScripts):
(WebCore::RenderTheme::mediaControlsFormattedStringForDuration):
(WebCore::RenderTheme::extraMediaControlsStyleSheet): Deleted.
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::mediaControlsScripts):
(WebCore::RenderThemeAdwaita::mediaControlsStyleSheet):
(WebCore::RenderThemeAdwaita::mediaControlsFormattedStringForDuration):
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::purgeCaches):
* Source/WebCore/style/InspectorCSSOMWrappers.cpp:
(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers):
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
* Source/WebCore/style/UserAgentStyle.h:
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformWPE.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

Canonical link: https://commits.webkit.org/289230@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list