[webkit-changes] [WebKit/WebKit] 4e5c6a: [scroll-animations] CSS Animations should update t...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e5c6a773a47c29137395c835b78b69740529a7f
      https://github.com/WebKit/WebKit/commit/4e5c6a773a47c29137395c835b78b69740529a7f
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-01-21 (Tue, 21 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-deferred-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt
    M Source/WebCore/animation/AnimationTimelinesController.cpp
    M Source/WebCore/animation/AnimationTimelinesController.h
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/CSSAnimation.h

  Log Message:
  -----------
  [scroll-animations] CSS Animations should update their timeline if another element creates a timeline for that name
https://bugs.webkit.org/show_bug.cgi?id=286301
rdar://problem/143322856

Reviewed by Tim Nguyen.

In the case where an element sets a new `scroll-timeline-name` or `view-timeline-name` property to a value that
had previously been set on another element, we should make sure to update any CSS Animation that was created
with an `animation-timeline` value set to that very name.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-deferred-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt:
* Source/WebCore/animation/AnimationTimelinesController.cpp:
(WebCore::AnimationTimelinesController::registerNamedScrollTimeline):
(WebCore::AnimationTimelinesController::updateCSSAnimationsAssociatedWithNamedTimeline):
(WebCore::AnimationTimelinesController::registerNamedViewTimeline):
* Source/WebCore/animation/AnimationTimelinesController.h:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
(WebCore::CSSAnimation::syncStyleOriginatedTimeline):
* Source/WebCore/animation/CSSAnimation.h:

Canonical link: https://commits.webkit.org/289226@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications