[webkit-changes] [WebKit/WebKit] 4cb86a: ign.com: [macOS] `space` key does not pause video ...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4cb86a23da0aa6ab27e3317221560ebbd5e15030
      https://github.com/WebKit/WebKit/commit/4cb86a23da0aa6ab27e3317221560ebbd5e15030
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-01-21 (Tue, 21 Jan 2025)

  Changed paths:
    M LayoutTests/media/video-mouse-focus-expected.txt
    M LayoutTests/media/video-mouse-focus.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h

  Log Message:
  -----------
  ign.com: [macOS] `space` key does not pause video in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=286330
rdar://138037616

Reviewed by Jean-Yves Avenard.

The “Space key” initially also does not work in Chrome / Firefox, but clicking on the video makes the space key work there. It's not the case in Safari.

In Safari, you need to tab to the video. But in all cases, the video requires focus before the space key works.

To fix the behavior difference in Safari, we make the video mouse focusable to match Firefox / Chrome.

This effectively reverts 94794 at main, given the outline it was removing is no longer there (since the introduction of `:focus-visible`). A test is also added
for the outline.

* LayoutTests/media/video-mouse-focus-expected.txt:
* LayoutTests/media/video-mouse-focus.html:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isMouseFocusable const): Deleted.
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/289220@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications