[webkit-changes] [WebKit/WebKit] d2ba57: Update assertion in BrowsingContextGroup::removeFr...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2ba577b98c15798f39a6b1516f28ecc44586866
      https://github.com/WebKit/WebKit/commit/d2ba577b98c15798f39a6b1516f28ecc44586866
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-21 (Tue, 21 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Update assertion in BrowsingContextGroup::removeFrameProcess
https://bugs.webkit.org/show_bug.cgi?id=286321
rdar://143346573

Reviewed by Charlie Wolfe.

When a process crashes or is terminated for other reasons, if we
then load the same domain in the same frame, we create the new FrameProcess
for the provisional navigation before destroying the old FrameProcess,
and we hit the assertion in BrowsingContextGroup::removeFrameProcess.
I added a unit test that hit the assertion in debug builds.
The updated assertion matches the existing assertion case in
BrowsingContextGroup::addFrameProcess.

* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::removeFrameProcess):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, ProcessTerminationReason)):

Canonical link: https://commits.webkit.org/289216@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications