[webkit-changes] [WebKit/WebKit] 765915: Make WebFullScreenManagerProxy work with site isol...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 765915c1480ee371d3a906af8af4247b94ca0860
      https://github.com/WebKit/WebKit/commit/765915c1480ee371d3a906af8af4247b94ca0860
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-21 (Tue, 21 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in

  Log Message:
  -----------
  Make WebFullScreenManagerProxy work with site isolation
https://bugs.webkit.org/show_bug.cgi?id=286020

Reviewed by Jer Noble.

Before this PR we were sending all IPC to protectedLegacyMainFrameProcess,
which works fine if site isolation is off or if the fullscreen element is
in the main frame process.  But with site isolation, it might not be, such
as with many embedded youtube videos.  This changes the messages to be sent
to the last process that sent WebFullScreenManagerProxy::enterFullScreen.
It still doesn't make the element fill the entirety of the screen with site
isolation on, but it does make the content fill the screen with future work
to change the size of the element, which isn't working with site isolation
on for some unknown reason.

* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::sharedPreferencesForWebProcess const):
(WebKit::WebFullScreenManagerProxy::sendToWebProcess):
(WebKit::WebFullScreenManagerProxy::didEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::willExitFullScreen):
(WebKit::WebFullScreenManagerProxy::didExitFullScreen):
(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen):
(WebKit::WebFullScreenManagerProxy::requestRestoreFullScreen):
(WebKit::WebFullScreenManagerProxy::requestExitFullScreen):
(WebKit::WebFullScreenManagerProxy::saveScrollPosition):
(WebKit::WebFullScreenManagerProxy::restoreScrollPosition):
(WebKit::WebFullScreenManagerProxy::setFullscreenInsets):
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideDuration):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in:

Canonical link: https://commits.webkit.org/289198@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications