[webkit-changes] [WebKit/WebKit] 82f304: Don't update column position in StyleDidChange

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82f304b2ff6b7848247973d468ad00d18e474c73
      https://github.com/WebKit/WebKit/commit/82f304b2ff6b7848247973d468ad00d18e474c73
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2025-01-21 (Tue, 21 Jan 2025)

  Changed paths:
    A LayoutTests/fast/table/relayout-out-of-flow-with-border-spacing-expected.txt
    A LayoutTests/fast/table/relayout-out-of-flow-with-border-spacing.html
    M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  -----------
  Don't update column position in StyleDidChange

https://bugs.webkit.org/show_bug.cgi?id=286271
rdar://143276513

Reviewed by Alan Baradlay.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/src.git/+/d3c625b0b03346472e45dc1fda33d35b1d40efd3

StyleDidChange set the first column position to the horizontal border
spacing value regardless of whether this value changed or not.

During relayout, a table cell because it has out-of-flow content which
needs layout, the first effective column position is set wrongly. It gets
its value from this line but the spacing is also subtracted once more in
RenderTableSection::setcelllogicalwidth(). So this patch is to remove this
one.

* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* LayoutTests/fast/table/relayout-out-of-flow-with-border-spacing-expected.txt:
* LayoutTests/fast/table/relayout-out-of-flow-with-border-spacing.html:

Canonical link: https://commits.webkit.org/289178@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications