[webkit-changes] [WebKit/WebKit] d94773: [css-anchor-position-1] Gate anchor-center behind ...

Kiet Ho noreply at github.com
Mon Jan 20 22:11:07 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9477327f62271df84745c05588d309783c3b4d2
      https://github.com/WebKit/WebKit/commit/d9477327f62271df84745c05588d309783c3b4d2
  Author: Kiet Ho <kiet.ho at apple.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    A LayoutTests/fast/css/css-anchor-position/anchor-feature-disabled-expected.txt
    A LayoutTests/fast/css/css-anchor-position/anchor-feature-disabled.html
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp

  Log Message:
  -----------
  [css-anchor-position-1] Gate anchor-center behind CSS Anchor Positioning feature
rdar://143097581
https://bugs.webkit.org/show_bug.cgi?id=286112

Reviewed by Tim Nguyen.

anchor-center should be gated behind the CSS Anchor Positioning feature,
but it wasn't. Fixes this by not parsing anchor-center if the feature is
not enabled.

* LayoutTests/fast/css/css-anchor-position/anchor-feature-disabled-expected.txt: Added.
* LayoutTests/fast/css/css-anchor-position/anchor-feature-disabled.html: Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp:
(WebCore::CSSPropertyParserHelpers::isSelfPositionKeyword):
(WebCore::CSSPropertyParserHelpers::consumeSelfPositionOverflowPosition):
(WebCore::CSSPropertyParserHelpers::consumeAlignSelf):
(WebCore::CSSPropertyParserHelpers::consumeJustifySelf):
(WebCore::CSSPropertyParserHelpers::consumeAlignItems):
(WebCore::CSSPropertyParserHelpers::consumeJustifyItems):
(WebCore::CSSPropertyParserHelpers::isSelfPositionOrLeftOrRightKeyword): Deleted.

Canonical link: https://commits.webkit.org/289170@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list