[webkit-changes] [WebKit/WebKit] 2c15e1: [WebGPU] Pipeline layout for compute pipelines is ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c15e1198606b092facb2395ba04471e7fcd53a7
      https://github.com/WebKit/WebKit/commit/2c15e1198606b092facb2395ba04471e7fcd53a7
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_1380-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_1380.html
    A LayoutTests/fast/webgpu/regression/repro_1380b-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_1380b.html
    A LayoutTests/fast/webgpu/regression/repro_1380c-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_1380c.html
    A LayoutTests/fast/webgpu/regression/repro_1380d-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_1380d.html
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/IsValidToUseWith.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Pipeline layout for compute pipelines is not validated to be valid
https://bugs.webkit.org/show_bug.cgi?id=286250
rdar://143249146

Reviewed by Tadeu Zagallo.

Unlike RenderPipelines, creating a ComputePipeline did not check if the
associated PipelineLayout was invalid. Attempting to do so should result
in an invalid ComputePipeline according to the WebGPU specification, see
https://www.w3.org/TR/webgpu/#dom-gpudevice-createcomputepipeline

* LayoutTests/fast/webgpu/regression/repro_1380-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_1380.html: Added.
* LayoutTests/fast/webgpu/regression/repro_1380b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_1380b.html: Added.
* LayoutTests/fast/webgpu/regression/repro_1380c-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_1380c.html: Added.
* LayoutTests/fast/webgpu/regression/repro_1380d-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_1380d.html: Added.
Add associated regression tests and expectations.

* Source/WebGPU/WebGPU/ComputePipeline.mm:
* Source/WebGPU/WebGPU/IsValidToUseWith.h:
(WebGPU::isValidToUseWithDevice):
* Source/WebGPU/WebGPU/RenderPipeline.mm:

Canonical link: https://commits.webkit.org/289162@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications