[webkit-changes] [WebKit/WebKit] e6097b: [Cleanup] Move RenderElement::establishesIndepende...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6097b94be5f9ba1057bc52aacb13a5055d8ff68
      https://github.com/WebKit/WebKit/commit/e6097b94be5f9ba1057bc52aacb13a5055d8ff68
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlock.h
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderElement.h
    M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  -----------
  [Cleanup] Move RenderElement::establishesIndependentFormattingContext to RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=286225

Reviewed by Antti Koivisto.

1. Similar to webkit.org/b/286216. Establishing a formatting context applies to containers.
2. Simplify RenderGrid's establishesIndependentFormattingContext (there's a confusing part where isSubgrid() also calls establishesIndependentFormattingContext).

This is in preparation for de-virtualizing establishesIndependentFormattingContext.

* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::establishesIndependentFormattingContext const):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::establishesIndependentFormattingContext const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::establishesIndependentFormattingContext const): Deleted.
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::styleDidChange):
(WebCore::RenderGrid::isSubgrid const):
(WebCore::RenderGrid::establishesIndependentFormattingContext const):

Canonical link: https://commits.webkit.org/289160@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications