[webkit-changes] [WebKit/WebKit] ab8683: [TexMap] Incorrect damage information produced for...

Pawel Lampe noreply at github.com
Mon Jan 20 10:51:12 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab86837116be8c4fced269c90d9cea2ff3e3204e
      https://github.com/WebKit/WebKit/commit/ab86837116be8c4fced269c90d9cea2ff3e3204e
  Author: Pawel Lampe <plampe at igalia.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
    M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsScene.cpp

  Log Message:
  -----------
  [TexMap] Incorrect damage information produced for animations with blur
https://bugs.webkit.org/show_bug.cgi?id=277484

Reviewed by Nikolas Zimmermann.

This change:
- adds a mechanism to collect damage from replica/filter/mask's
  overlap regions
- makes the damage being propagated always when dirty region changes
- removes two workarounds invalidating whole layer in some cases
so that damage from ongoing animations is colleced correctly now.

* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::collectDamageRecursive):
(WebCore::TextureMapperLayer::collectDamageSelfAndChildren):
(WebCore::TextureMapperLayer::collectDamageSelfChildrenReplicaFilterAndMask):
(WebCore::TextureMapperLayer::collectDamageSelfChildrenFilterAndMask):
(WebCore::TextureMapperLayer::computeConsolidatedOverlapRegionRects):
(WebCore::TextureMapperLayer::paintSelfChildrenFilterAndMask):
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp:
(WebCore::CoordinatedPlatformLayer::setDamage):
(WebCore::CoordinatedPlatformLayer::flushCompositingState):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):

Canonical link: https://commits.webkit.org/289158@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list