[webkit-changes] [WebKit/WebKit] 206e15: Generate all style builder functions for font-feat...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 206e15e58c13e2648c97490244dbe34b1e113a39
      https://github.com/WebKit/WebKit/commit/206e15e58c13e2648c97490244dbe34b1e113a39
  Author: Antti Koivisto <antti at apple.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/inheritance-expected.txt
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/process-css-properties.py
    M Source/WebCore/platform/graphics/FontCascadeDescription.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  Generate all style builder functions for font-feature-settings
https://bugs.webkit.org/show_bug.cgi?id=286258
rdar://143263787

Reviewed by Alan Baradlay.

They are handwritten and incomplete. This becomes a problem for future optimizations.

 LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/inheritance-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/process-css-properties.py:

Allow move-only setters.

* Source/WebCore/platform/graphics/FontCascadeDescription.h:
(WebCore::FontCascadeDescription::initialFeatureSettings):
(WebCore::FontCascadeDescription::initialVariationSettings):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueContent):

Also fix reseting content alt text. All paths for a given property should set all fields.

(WebCore::Style::BuilderCustom::applyInitialFontFeatureSettings): Deleted.
(WebCore::Style::BuilderCustom::applyInheritFontFeatureSettings): Deleted.
(WebCore::Style::BuilderCustom::applyInitialWebkitMaskImage): Deleted.
(WebCore::Style::BuilderCustom::applyInheritWebkitMaskImage): Deleted.
(WebCore::Style::BuilderCustom::applyInitialFontVariationSettings): Deleted.
(WebCore::Style::BuilderCustom::applyInheritFontVariationSettings): Deleted.

Canonical link: https://commits.webkit.org/289152@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications