[webkit-changes] [WebKit/WebKit] 212b12: [line-clamp] ASSERT in RenderTreeNeedsLayoutChecke...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 212b12a438f42b523391864a06d0ae90bef1aa51
      https://github.com/WebKit/WebKit/commit/212b12a438f42b523391864a06d0ae90bef1aa51
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    A LayoutTests/fast/inline/line-clamp-discarded-content-assert-expected.txt
    A LayoutTests/fast/inline/line-clamp-discarded-content-assert.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h

  Log Message:
  -----------
  [line-clamp] ASSERT in RenderTreeNeedsLayoutChecker when clamped content has floats
https://bugs.webkit.org/show_bug.cgi?id=286187

Reviewed by Antti Koivisto.

Make sure discarded renderers (i.e. not laid out during line layout due to line-clamp) get their needsLayout flag cleared.

* LayoutTests/fast/inline/line-clamp-discarded-content-assert-expected.txt: Added.
* LayoutTests/fast/inline/line-clamp-discarded-content-assert.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:

Canonical link: https://commits.webkit.org/289149@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications