[webkit-changes] [WebKit/WebKit] c6956e: [JSC] Report extra memory allocated by JSC::Except...

[Max Rottenkolber]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6956e26bf70f2cbf440ea72220975c3dcc4c99f
      https://github.com/WebKit/WebKit/commit/c6956e26bf70f2cbf440ea72220975c3dcc4c99f
  Author: Max Rottenkolber <maximilian at igalia.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    M Source/JavaScriptCore/runtime/Exception.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyException.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyException.h

  Log Message:
  -----------
  [JSC] Report extra memory allocated by JSC::Exception and JSC::JSWebAssemblyException
https://bugs.webkit.org/show_bug.cgi?id=283108

Reviewed by Justin Michaud.

JSTests/wasm/stress/cc-int-to-int-cross-module-with-exception.js would
exceed the memory footprint limit when run with --memory-limited. This
was due to it allocating a lot of exceptions, while the size of the
allocated exceptions reported to the GC was wildly underestimated.
This lead to the GC kicking in too late because it is unable to track the
true eden size.

This is resolved by calling Heap::reportExtraMemoryAllocated on
on the stacktrace and payload allocated by JSC::Exception and
JSC::JSWebAssemblyException respectively.

* Source/JavaScriptCore/runtime/Exception.cpp:
(JSC::Exception::finishCreation):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyException.cpp:
(JSC::JSWebAssemblyException::finishCreation):
(JSC::JSWebAssemblyException::visitChildrenImpl):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyException.h:

Canonical link: https://commits.webkit.org/289147@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications