[webkit-changes] [WebKit/WebKit] fa7b6d: REGRESSION(288829 at main) [CMake] Build failure with...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa7b6d6d744766a6847a4fd493c27393daf1fc9b
      https://github.com/WebKit/WebKit/commit/fa7b6d6d744766a6847a4fd493c27393daf1fc9b
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2025-01-18 (Sat, 18 Jan 2025)

  Changed paths:
    M Source/WebCore/rendering/shapes/LayoutShape.cpp
    M Source/WebCore/style/values/shapes/StylePolygonFunction.cpp

  Log Message:
  -----------
  REGRESSION(288829 at main) [CMake] Build failure with clang-18 crashing on Vector::map and complex LengthPercentage templates
https://bugs.webkit.org/show_bug.cgi?id=286004

Reviewed by Fujii Hironori.

Related to llvm's https://github.com/llvm/llvm-project/pull/93206, a fix
that's part of clang-19. As clang-18 is still quite new and the version
in distros like Ubuntu 24.04 LTS, we are adding a workaround on this
commit.

Thanks to Fujii Hironori for the suggested simpler fix of removing the
lambda return type instead of replacing the map with a for loop.

* Source/WebCore/rendering/shapes/LayoutShape.cpp:
(WebCore::LayoutShape::createShape):
* Source/WebCore/style/values/shapes/StylePolygonFunction.cpp:
(WebCore::Style::PathComputation<Polygon>::operator):

Canonical link: https://commits.webkit.org/289103@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications