[webkit-changes] [WebKit/WebKit] 1798cc: REGRESSION(285576 at main): TestWebKitAPI.UnifiedPDF....

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1798cc41abdccbb054898d0b741d9580f388dfe2
      https://github.com/WebKit/WebKit/commit/1798cc41abdccbb054898d0b741d9580f388dfe2
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  -----------
  REGRESSION(285576 at main): TestWebKitAPI.UnifiedPDF.KeyboardScrollingInSinglePageMode is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=286184
rdar://143151459

Reviewed by Wenson Hsieh.

The aforementioned API test was timing out because we were dispatching
NSEvents created through -[NSEvent keyEventWithType:...] with the wrong
characters: and keyCode: arguments, hence the default keyboard event
handler could not identify a focus direction appropriate for the arrow
presses.

This patch addresses the issue by correcting the arguments, and also
introduces a helper lambda `pressKey()` to make the test DRY-er.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):

Canonical link: https://commits.webkit.org/289100@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications