[webkit-changes] [WebKit/WebKit] 2b3778: Remove RefPtr<LocalFrame> from Editor::Command

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b37780921fbbde3970c73f477b41a8966bec6e1
      https://github.com/WebKit/WebKit/commit/2b37780921fbbde3970c73f477b41a8966bec6e1
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M Source/WebCore/editing/Editor.h
    M Source/WebCore/editing/EditorCommand.cpp

  Log Message:
  -----------
  Remove RefPtr<LocalFrame> from Editor::Command
https://bugs.webkit.org/show_bug.cgi?id=285860
rdar://142821974

Reviewed by Ryosuke Niwa.

The Editor::Command does not need to prevent the LocalFrame
from being destroyed.  If the LocalFrame is destroyed, I added
some null checks and we shouldn't interact with the LocalFrame.

* Source/WebCore/editing/Editor.h:
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::Editor::Command::Command):
(WebCore::Editor::Command::frame const):
(WebCore::Editor::Command::execute const):
(WebCore::Editor::Command::isSupported const):
(WebCore::Editor::Command::isEnabled const):
(WebCore::Editor::Command::state const):
(WebCore::Editor::Command::value const):
(WebCore::Editor::Command::allowExecutionWhenDisabled const):

Canonical link: https://commits.webkit.org/289096@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications