[webkit-changes] [WebKit/WebKit] 982e09: Use arrays instead of sets in generate-process-syn...

Alex Christensen noreply at github.com
Fri Jan 17 16:58:58 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 982e09ae1be8227a09329367c4c5924dbc6c755c
      https://github.com/WebKit/WebKit/commit/982e09ae1be8227a09329367c4c5924dbc6c755c
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M Source/WebCore/Scripts/generate-process-sync-data.py
    M Source/WebCore/Scripts/tests/DocumentSyncData.h
    M Source/WebCore/Scripts/tests/ProcessSyncClient.h
    M Source/WebCore/Scripts/tests/ProcessSyncData.h

  Log Message:
  -----------
  Use arrays instead of sets in generate-process-sync-data.py
rdar://143026894
https://bugs.webkit.org/show_bug.cgi?id=286172

Reviewed by Brady Eidson.

We are seeing some nondeterministic output reordering the members of the DocumentSyncData
class in the generated header.  I found that we use python sets, which could be the cause.
I replaced them with uses of arrays.

Also don't use sorted() because that could be a cause of nondeterministic output.

* Source/WebCore/Scripts/generate-process-sync-data.py:
(sorted_headers_from_datas):
(sort_data_lists):
* Source/WebCore/Scripts/tests/DocumentSyncData.h:

Canonical link: https://commits.webkit.org/289090@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list