[webkit-changes] [WebKit/WebKit] 39e8e2: Treat web extension resources as UTF-8 by default.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39e8e2a5ef2b52761cacc02231d039d55632741e
      https://github.com/WebKit/WebKit/commit/39e8e2a5ef2b52761cacc02231d039d55632741e
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M Source/WebKit/Platform/cocoa/CocoaHelpers.h
    M Source/WebKit/Platform/cocoa/CocoaHelpers.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtension.h

  Log Message:
  -----------
  Treat web extension resources as UTF-8 by default.
https://webkit.org/b/286165
rdar://143079179

Reviewed by Brian Weinstein.

Stop auto-detecting text encoding when handling string resources, just default to UTF-8.
This matches Chrome and Firefox and avoid the more costly decoding detection.

Also cache resources as String or Data using a variant, so we can avoid encoding and decoding
to and from UTF-8 when accessing existing resources.

* Source/WebKit/Platform/cocoa/CocoaHelpers.h:
* Source/WebKit/Platform/cocoa/CocoaHelpers.mm:
(WebKit::toDataMap):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::WebExtension):
(WebKit::WebExtension::resourceDataForPath):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::localizedResourceData):
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::resourceStringForPath):
* Source/WebKit/UIProcess/Extensions/WebExtension.h:

Canonical link: https://commits.webkit.org/289086@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications