[webkit-changes] [WebKit/WebKit] 0e9ce0: REGRESSION (286183 at main): [iOS] Safari summarizati...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e9ce0f18a23cc2001e4a7ad8228d925791f5f8b
      https://github.com/WebKit/WebKit/commit/0e9ce0f18a23cc2001e4a7ad8228d925791f5f8b
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTextPreview.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPageAPI.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm

  Log Message:
  -----------
  REGRESSION (286183 at main): [iOS] Safari summarization is missing pondering animation
https://bugs.webkit.org/show_bug.cgi?id=286091
rdar://142447426

Reviewed by Richard Robinson and Abrar Rahman Protyasha.

286183 at main incorrectly modified `-[WKWebView _targetedPreviewForElementWithID:completionHandler:]`
which is unrelated to proofreading, and used only by Safari. The `WKWebView`
should be the preview container, not the `WKScrollView`. Using the incorrect
container results in the targeted preview being misplaced.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _targetedPreviewForElementWithID:completionHandler:]):
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTextPreview.mm: Added.
(TestWebKitAPI::TEST(ElementTextPreview, PreviewForElement)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPageAPI.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

Canonical link: https://commits.webkit.org/289068@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications