[webkit-changes] [WebKit/WebKit] e638aa: [Cocoa] Align <datalist> dropdown keyboard interac...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e638aadaf01611f07793a35ef8dc7b77e7ad4dec
      https://github.com/WebKit/WebKit/commit/e638aadaf01611f07793a35ef8dc7b77e7ad4dec
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    A LayoutTests/fast/forms/datalist/datalist-hide-using-escape-key-expected.txt
    A LayoutTests/fast/forms/datalist/datalist-hide-using-escape-key.html
    M LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-on-keydown.html
    M LayoutTests/fast/forms/datalist/datalist-textinput-keydown-expected.txt
    M LayoutTests/fast/forms/datalist/datalist-textinput-keydown.html
    M LayoutTests/fast/forms/datalist/datalist-textinput-suggestions-order.html
    A LayoutTests/platform/gtk/fast/forms/datalist/datalist-textinput-keydown-expected.txt
    M LayoutTests/platform/ipad/TestExpectations
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M LayoutTests/resources/ui-helper.js
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.cpp

  Log Message:
  -----------
  [Cocoa] Align <datalist> dropdown keyboard interactions with platform conventions
https://bugs.webkit.org/show_bug.cgi?id=286045
rdar://143012287

Reviewed by Abrar Rahman Protyasha.

- Up and down arrow keys should not cycle through options
- Escape key should dismiss the dropdown

* LayoutTests/fast/forms/datalist/datalist-hide-using-escape-key-expected.txt: Added.
* LayoutTests/fast/forms/datalist/datalist-hide-using-escape-key.html: Added.
* LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-on-keydown.html:
* LayoutTests/fast/forms/datalist/datalist-textinput-keydown-expected.txt:
* LayoutTests/fast/forms/datalist/datalist-textinput-keydown.html:
* LayoutTests/fast/forms/datalist/datalist-textinput-suggestions-order.html:
* LayoutTests/platform/gtk/fast/forms/datalist/datalist-textinput-keydown-expected.txt: Added.
* LayoutTests/platform/ipad/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.waitForDataListSuggestionsToChangeVisibility):
(window.UIHelper.isShowingDateTimePicker): Deleted.
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent):
* Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:
(-[WKDataListSuggestionsController moveSelectionByDirection:]):
* Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.cpp:
(WebKit::WebDataListSuggestionPicker::handleKeydownWithIdentifier):

Canonical link: https://commits.webkit.org/289067@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications