[webkit-changes] [WebKit/WebKit] 5ed85e: REGRESSION(289034 at main): ASSERTION FAILED: result ...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ed85eba0c21690f977dde44fda16360824208d6
      https://github.com/WebKit/WebKit/commit/5ed85eba0c21690f977dde44fda16360824208d6
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  REGRESSION(289034 at main): ASSERTION FAILED: result in WebKit::FrameLoadState::removeObserver(FrameLoadStateObserver &) for http/tests/navigation/page-cache-requestAnimationFrame.html
https://bugs.webkit.org/show_bug.cgi?id=286121

Reviewed by Pascoe.

When a page is suspended, the observer is removed from its main frame. So, we need to add the observer
back when unsuspending the page. Also, update the variable name to better reflect its purpose.

* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::initializeWebPage):
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToProvisionalPage):

Canonical link: https://commits.webkit.org/289059@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications