[webkit-changes] [WebKit/WebKit] 661da2: Videos using `transform-style: separated` loose th...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 661da23a2ffacb724e573950eade16beefb1b160
      https://github.com/WebKit/WebKit/commit/661da23a2ffacb724e573950eade16beefb1b160
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    A LayoutTests/platform/visionos/transforms/separated-video-expected.txt
    A LayoutTests/platform/visionos/transforms/separated-video.html
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

  Log Message:
  -----------
  Videos using `transform-style: separated` loose their controls
https://bugs.webkit.org/show_bug.cgi?id=286070
<rdar://140916909>

Reviewed by Simon Fraser.

Separated layers have the `contentsRectClipsDescendants` flag on.
This caused the controls to be rendered behind the video because of a
small ordering issue, originally from 236998 at main.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateSublayerList):
Append the contents layer _before_ the child layers in the
`clippingLayerHostsChildren` case.

* LayoutTests/platform/visionos/transforms/separated-video-expected.txt: Added.
* LayoutTests/platform/visionos/transforms/separated-video.html: Added.
Add a test, the tests from 236998 at main remain unchanged.

Canonical link: https://commits.webkit.org/289046@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications