[webkit-changes] [WebKit/WebKit] 693d75: [Site Isolation] Avoid reusing the main frame afte...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 693d7534811e6525561c884b48539ff5454ed010
      https://github.com/WebKit/WebKit/commit/693d7534811e6525561c884b48539ff5454ed010
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M Source/WebKit/Shared/WebBackForwardListFrameItem.cpp
    M Source/WebKit/Shared/WebBackForwardListFrameItem.h
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalPageProxy.h
    M Source/WebKit/UIProcess/WebBackForwardList.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [Site Isolation] Avoid reusing the main frame after cross-site navigation
https://bugs.webkit.org/show_bug.cgi?id=286095
rdar://143077012

Reviewed by Pascoe.

This relands 288547 at main without breaking an internal page loading benchmark. I need to remove a
siteIsolationEnabled check before calling FrameLoadState::addObserver in
WebPageProxy::swapToProvisionalPage, since we now switch main frames when navigating in the benchmark.

* Source/WebKit/Shared/WebBackForwardListFrameItem.cpp:
(WebKit::WebBackForwardListFrameItem::sharesAncestor const):
(WebKit::WebBackForwardListFrameItem::hasAncestorFrame): Deleted.
* Source/WebKit/Shared/WebBackForwardListFrameItem.h:
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):
* Source/WebKit/UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToProvisionalPage):
(WebKit::WebPageProxy::commitProvisionalPage):

Canonical link: https://commits.webkit.org/289034@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications