[webkit-changes] [WebKit/WebKit] 130169: Fix ObjC memory leaks

Alex Christensen noreply at github.com
Thu Jan 16 14:53:19 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 130169a292024b9bfca8225def5a68c1866733ce
      https://github.com/WebKit/WebKit/commit/130169a292024b9bfca8225def5a68c1866733ce
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm
    M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm
    M Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
    M Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm

  Log Message:
  -----------
  Fix ObjC memory leaks
https://bugs.webkit.org/show_bug.cgi?id=286027
rdar://142998270

Reviewed by Abrar Rahman Protyasha and Geoffrey Garen.

grep -r '\[alloc' Source | grep -v adopt

The change in AccessibilityObjectIOS.mm wasn't a memory leak, but I
think it's good to adopt in the same statement as the allocation.

* Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AXRemoteFrame::initializePlatformElementWithRemoteToken):
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(WebKit::PlaybackSessionInterfaceLMK::spatialVideoMetadataChanged):
(WebKit::PlaybackSessionInterfaceLMK::nowPlayingMetadataChanged):
* Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::modelElementLoadRemotePreview):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
(WebKit::LocalConnection::verifyUser):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::toASCExtensions):
* Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController playerView]):
(-[WebVideoFullscreenController windowDidLoad]):
(-[WebVideoFullscreenController windowDidEnterFullScreen:]):
(-[WebVideoFullscreenController windowWillExitFullScreen:]):

Canonical link: https://commits.webkit.org/289029@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list