[webkit-changes] [WebKit/WebKit] 773ecf: Receiver output should trigger using audio chat m...

youennf noreply at github.com
Thu Jan 16 05:04:17 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 773ecfac9b55348fb9be663e8b2c9d08923d0b06
      https://github.com/WebKit/WebKit/commit/773ecfac9b55348fb9be663e8b2c9d08923d0b06
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm
    M Source/WebCore/platform/audio/ios/AudioSessionIOS.mm
    M Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm

  Log Message:
  -----------
  Receiver output should  trigger using audio chat mode when microphone is on
rdar://141685006
https://bugs.webkit.org/show_bug.cgi?id=286054

Reviewed by Jean-Yves Avenard.

We were previously using default mode when capturing microphone while trying to output audio to receiver.
Instead, we now use voice chat mode in that case, this allows smooth audio transition.

In addition, we reset whether to use receiver if the audio output id is set back to the empty string.

We do not expose voice chat as a specific AudioSession mode.
Instead we consider it is a special case of AudioSession::Mode::VideoChat.

Manually tested.

* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm:
* Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSessionIOS::setCategory):
(WebCore::AudioSessionIOS::mode const):
* Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::setPreferredSpeakerID):

Canonical link: https://commits.webkit.org/289006@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list