[webkit-changes] [WebKit/WebKit] 406f6c: [scroll-animations] Animation-range values provide...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 406f6c335d9f223f5c6f081a787311ee33e1f426
      https://github.com/WebKit/WebKit/commit/406f6c335d9f223f5c6f081a787311ee33e1f426
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-timeline-range-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-get-set-range-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-range-expected.txt
    M Source/WebCore/animation/TimelineRange.cpp
    M Source/WebCore/animation/TimelineRange.h
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h

  Log Message:
  -----------
  [scroll-animations] Animation-range values provided by JS bindings should be resolved when needed
https://bugs.webkit.org/show_bug.cgi?id=285946
rdar://142910399

Reviewed by Antoine Quint.

We should resolve animation-range values provided through the JS API when needed to take into account changes
to scroll container size, font size, etc. This is a similar fix to the one made for ViewTimeline insets.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-range-animation.html:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-timeline-range-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-range-expected.txt:
* Source/WebCore/animation/AnimationTimelinesController.cpp:
(WebCore::AnimationTimelinesController::registerNamedScrollTimeline):
(WebCore::AnimationTimelinesController::setTimelineForName):
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::intervalForAttachmentRange const):
* Source/WebCore/animation/TimelineRange.cpp:
(WebCore::SingleTimelineRange::lengthForCSSValue):
(WebCore::SingleTimelineRange::parse):
* Source/WebCore/animation/TimelineRange.h:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::intervalForAttachmentRange const):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::autoAlignStartTime):
(WebCore::WebAnimation::setBindingsRangeStart):
(WebCore::WebAnimation::setBindingsRangeEnd):
(WebCore::WebAnimation::range):
(WebCore::WebAnimation::progressBasedTimelineSourceDidChangeMetrics):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::range const): Deleted.

Canonical link: https://commits.webkit.org/288986@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications