[webkit-changes] [WebKit/WebKit] c16514: [scroll-animations] JS override for animation-rang...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c16514b883b241c4b56e47dee2837cd982a94354
      https://github.com/WebKit/WebKit/commit/c16514b883b241c4b56e47dee2837cd982a94354
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-range-ignored-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-range-ignored.html
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/CSSAnimation.h
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h

  Log Message:
  -----------
  [scroll-animations] JS override for animation-range should be per property
https://bugs.webkit.org/show_bug.cgi?id=285883
rdar://142841187

Reviewed by Antoine Quint.

Setting animation-range via JS should override only on the property set (ie setting animation-range-start
via JS API should only override animation-range-start and not animation-range-end as well).

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-range-ignored-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-range-ignored.html:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
(WebCore::CSSAnimation::setBindingsRangeStart):
(WebCore::CSSAnimation::setBindingsRangeEnd):
* Source/WebCore/animation/CSSAnimation.h:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::intervalForAttachmentRange const):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::setRangeStart):
(WebCore::WebAnimation::setRangeEnd):
(WebCore::WebAnimation::setRange): Deleted.
* Source/WebCore/animation/WebAnimation.h:

Canonical link: https://commits.webkit.org/288973@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications