[webkit-changes] [WebKit/WebKit] 5b32e9: element.children index getter returns a wrong elem...

Ryosuke Niwa noreply at github.com
Wed Jan 15 15:04:11 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b32e928bc978e067a412a2edb71e6da194acc6a
      https://github.com/WebKit/WebKit/commit/5b32e928bc978e067a412a2edb71e6da194acc6a
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    A LayoutTests/fast/dom/collection-children-backwards-expected.txt
    A LayoutTests/fast/dom/collection-children-backwards.html
    M Source/WebCore/html/CollectionTraversalInlines.h

  Log Message:
  -----------
  element.children index getter returns a wrong element when traversing backwards
https://bugs.webkit.org/show_bug.cgi?id=285705
rdar://142838915

Reviewed by Simon Fraser.

The bug was caused by CollectionTraversal<CollectionTraversalType::ChildrenOnly>::last
traversing from the beginning instead of the end. The PR fixes the bug accordingly.

* LayoutTests/fast/dom/collection-children-backwards-expected.txt: Added.
* LayoutTests/fast/dom/collection-children-backwards.html: Added.
* Source/WebCore/html/CollectionTraversalInlines.h:
(WebCore::CollectionTraversal<CollectionTraversalType::ChildrenOnly>::last):

Canonical link: https://commits.webkit.org/288969@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list