[webkit-changes] [WebKit/WebKit] 009fd8: [WebDriver][BiDi] Update imported selenium tests t...

Lauro Moura noreply at github.com
Wed Jan 15 12:45:14 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 009fd8f3eab3b6cc233928100a20e364df56e200
      https://github.com/WebKit/WebKit/commit/009fd8f3eab3b6cc233928100a20e364df56e200
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py
    A WebDriverTests/imported/selenium/common/src/web/fedcm/config.json
    M WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm.html
    A WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm_async.html
    A WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm_async_js.html
    A WebDriverTests/imported/selenium/common/src/web/fedcm/login.html
    A WebDriverTests/imported/selenium/common/src/web/fedcm/signin.html
    M WebDriverTests/imported/selenium/common/src/web/formPage.html
    M WebDriverTests/imported/selenium/common/src/web/javascriptPage.html
    A WebDriverTests/imported/selenium/common/src/web/locators_tests/locators.html
    A WebDriverTests/imported/selenium/common/src/web/modal_dialogs/modern_modal.html
    M WebDriverTests/imported/selenium/importer.json
    M WebDriverTests/imported/selenium/py/conftest.py
    M WebDriverTests/imported/selenium/py/selenium/__init__.py
    M WebDriverTests/imported/selenium/py/selenium/common/__init__.py
    M WebDriverTests/imported/selenium/py/selenium/common/exceptions.py
    M WebDriverTests/imported/selenium/py/selenium/types.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/__init__.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/input_device.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/pointer_input.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/wheel_input.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/cdp.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/script.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/session.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/by.py
    A WebDriverTests/imported/selenium/py/selenium/webdriver/common/fedcm/__init__.py
    A WebDriverTests/imported/selenium/py/selenium/webdriver/common/fedcm/account.py
    A WebDriverTests/imported/selenium/py/selenium/webdriver/common/fedcm/dialog.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/log.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/options.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/selenium_manager.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/service.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/common/virtual_authenticator.py
    A WebDriverTests/imported/selenium/py/selenium/webdriver/remote/client_config.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/command.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/errorhandler.py
    A WebDriverTests/imported/selenium/py/selenium/webdriver/remote/fedcm.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/file_detector.py
    A WebDriverTests/imported/selenium/py/selenium/webdriver/remote/locator_converter.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/remote_connection.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/shadowroot.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webdriver.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webelement.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/remote/websocket_connection.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/safari/options.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/safari/remote_connection.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/safari/service.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/safari/webdriver.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/support/event_firing_webdriver.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/support/relative_locator.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/support/wait.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/webkitgtk/service.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/wpewebkit/options.py
    M WebDriverTests/imported/selenium/py/selenium/webdriver/wpewebkit/service.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/alerts_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/bidi_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/cookie_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/correct_event_firing_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/driver_element_finding_tests.py
    A WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/fedcm_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/interactions_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/interactions_with_device_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/network.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/selenium_manager_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/takes_screenshots_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/typing_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/upload_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/visibility_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/webdriverwait_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/webserver.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py
    A WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/custom_element_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/remote_connection_tests.py
    A WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/remote_custom_locator_tests.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py
    A WebDriverTests/imported/selenium/py/test/selenium/webdriver/safari/__init__.py
    M WebDriverTests/imported/selenium/py/test/selenium/webdriver/safari/launcher_tests.py
    A WebDriverTests/imported/selenium/py/test/selenium/webdriver/safari/safari_service_tests.py

  Log Message:
  -----------
  [WebDriver][BiDi] Update imported selenium tests to a version using WebDriver BiDi instead of CDP
https://bugs.webkit.org/show_bug.cgi?id=283785

Reviewed by Carlos Garcia Campos and Carlos Alberto Lopez Perez.

Bump imported selenium python version to hash 7425162bbc, from Jan 8th,
2025. This version includes the required fixes to run the tests with
WebKitGTK and WPEWebKit.

As usual, the only downstream changes are only ones related to
commenting out the test classes for non-WebKit browsers.

This commit also adds a custom import finder for the WebDriver tests
selenium, to ensure we use this imported version of selenium instead
of the AutoInstall one used by other packages, which may lack fixes
or features.

To run the BiDi tests, we need to pass a `--bidi=1` flag to pytest. In
order to do this only when `ENABLE_WEBDRIVER_BIDI` is true, this commit
only updates the imported test suite. Actual support for the BiDi tests
will be added in a follow-up commit.

* Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Added
  custom finder
(WebDriverSeleniumFinder):
(WebDriverSeleniumFinder.__init__):
(WebDriverSeleniumFinder.find_spec):
* WebDriverTests/imported/selenium/common/src/web/fedcm/config.json: Added.
* WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm.html:
* WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm_async.html: Added.
* WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm_async_js.html: Added.
* WebDriverTests/imported/selenium/common/src/web/fedcm/login.html: Added.
* WebDriverTests/imported/selenium/common/src/web/fedcm/signin.html: Added.
* WebDriverTests/imported/selenium/common/src/web/formPage.html:
* WebDriverTests/imported/selenium/common/src/web/javascriptPage.html:
* WebDriverTests/imported/selenium/common/src/web/locators_tests/locators.html: Added.
* WebDriverTests/imported/selenium/common/src/web/modal_dialogs/modern_modal.html: Added.
* WebDriverTests/imported/selenium/importer.json:
* WebDriverTests/imported/selenium/py/conftest.py:
* WebDriverTests/imported/selenium/py/selenium/__init__.py:
* WebDriverTests/imported/selenium/py/selenium/common/__init__.py:
* WebDriverTests/imported/selenium/py/selenium/common/exceptions.py:
* WebDriverTests/imported/selenium/py/selenium/types.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/__init__.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/input_device.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/pointer_input.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/wheel_input.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/cdp.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/script.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/session.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/by.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/fedcm/__init__.py: Copied from WebDriverTests/imported/selenium/py/selenium/__init__.py.
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/fedcm/account.py: Added.
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/fedcm/dialog.py: Added.
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/log.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/options.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/selenium_manager.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/service.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/common/virtual_authenticator.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/client_config.py: Added.
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/command.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/errorhandler.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/fedcm.py: Added.
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/file_detector.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/locator_converter.py: Copied from WebDriverTests/imported/selenium/py/selenium/__init__.py.
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/remote_connection.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/shadowroot.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webdriver.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webelement.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/remote/websocket_connection.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/safari/options.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/safari/remote_connection.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/safari/service.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/safari/webdriver.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/support/event_firing_webdriver.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/support/relative_locator.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/support/wait.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/webkitgtk/service.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/wpewebkit/options.py:
* WebDriverTests/imported/selenium/py/selenium/webdriver/wpewebkit/service.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/alerts_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/bidi_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/cookie_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/correct_event_firing_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/driver_element_finding_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/fedcm_tests.py: Added.
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/interactions_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/interactions_with_device_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/network.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/selenium_manager_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/takes_screenshots_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/typing_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/upload_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/visibility_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/webdriverwait_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/webserver.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/custom_element_tests.py: Added.
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/remote_connection_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/remote_custom_locator_tests.py: Added.
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/safari/__init__.py: Copied from WebDriverTests/imported/selenium/py/selenium/__init__.py.
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/safari/launcher_tests.py:
* WebDriverTests/imported/selenium/py/test/selenium/webdriver/safari/safari_service_tests.py: Added.

Canonical link: https://commits.webkit.org/288959@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list