[webkit-changes] [WebKit/WebKit] 2891d4: [WebGPU] fast math leads to invalid code gen

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2891d44f19691717c6664ba86f89f275acfeef6c
      https://github.com/WebKit/WebKit/commit/2891d44f19691717c6664ba86f89f275acfeef6c
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WebGPU] fast math leads to invalid code gen
https://bugs.webkit.org/show_bug.cgi?id=285938
rdar://142906182

Reviewed by Tadeu Zagallo.

It is too easy to generate MSL with -ffmast-math which LLVM optimizes
more agressively than expected, due to LLVM being able
to prove a certain expression is Inf or NaN and can therefore
be discarded under fast math optimization rules.

Instead, use relaxed math which honors NaNs and Infs but still
largely preserves performance.

* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::createLibrary):

Canonical link: https://commits.webkit.org/288947@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications