[webkit-changes] [WebKit/WebKit] 3727ac: AX: content-visibility: hidden does not remove ele...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3727ac7f682278095aecd5714957126d38d72b13
      https://github.com/WebKit/WebKit/commit/3727ac7f682278095aecd5714957126d38d72b13
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    A LayoutTests/accessibility/details-summary-content-hidden-expected.txt
    A LayoutTests/accessibility/details-summary-content-hidden.html
    M LayoutTests/accessibility/mac/details-summary-expected.txt
    M LayoutTests/accessibility/mac/details-summary.html
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/html/HTMLDetailsElement.cpp
    M Source/WebCore/html/HTMLDetailsElement.h

  Log Message:
  -----------
  AX: content-visibility: hidden does not remove elements from the accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=285955
rdar://142915090

Reviewed by Chris Fleizach.

When an element has content-visibility:hidden, it should not be exposed in the accessibility tree. This commit fixes that.

This bug caused us to expose collapsed content in details elements, which is hidden with content-visibility:hidden after
https://github.com/WebKit/WebKit/commit/cd2f382c7dc0e50ae049f7e2420377e944ba60a8.

This patch was co-authored with Josh Hoffman (https://github.com/hoffmanjoshua).

* LayoutTests/accessibility/details-summary-content-hidden-expected.txt: Added.
* LayoutTests/accessibility/details-summary-content-hidden.html: Added.
* LayoutTests/accessibility/mac/details-summary-expected.txt:
* LayoutTests/accessibility/mac/details-summary.html:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::isNodeVisible const):
(WebCore::AXObjectCache::onStyleChange):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::isVisibilityHidden):
(WebCore::isRenderHidden):
(WebCore::AXObjectCache::onExpandedChanged): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::defaultObjectInclusion const):
(WebCore::AccessibilityObject::isWithinHiddenWebArea const):
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::toggleOpen): Deleted.
* Source/WebCore/html/HTMLDetailsElement.h:

Canonical link: https://commits.webkit.org/288940@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications