[webkit-changes] [WebKit/WebKit] a58a6d: Use enum to track the when a subgridded axis changes.

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a58a6d430c78df273436b728645db4c1436959e2
      https://github.com/WebKit/WebKit/commit/a58a6d430c78df273436b728645db4c1436959e2
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  -----------
  Use enum to track the when a subgridded axis changes.
https://bugs.webkit.org/show_bug.cgi?id=285941
rdar://problem/142907490

Reviewed by Vitor Roriz.

We currently use a bool from subgridDidChange to keep track of
if an axis changes in terms of being subgridded in some way (e.g. change from being subgridded
in rows to being subgridded in columns or even not being a subgrid at all anymore).
We use this information later in dirtyGrid() to perform some invalidation
on our parent grid and/or ancestor subgrids to inform them they will need
to place their items again. This patch changes the logic from using and
passing around a bool to using an enum class SubgridDidChange : bool.

* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::styleDidChange):
(WebCore::RenderGrid::subgridDidChange const):
(WebCore::RenderGrid::dirtyGrid):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/288925@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications