[webkit-changes] [WebKit/WebKit] c7f902: [GStreamer] Fix WebCore log identifier reporting

Philippe Normand noreply at github.com
Wed Jan 15 01:13:20 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7f90213eec5ca6e7bfb1f9eb200a288713bcfc4
      https://github.com/WebKit/WebKit/commit/c7f90213eec5ca6e7bfb1f9eb200a288713bcfc4
  Author: Philippe Normand <philn at igalia.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Fix WebCore log identifier reporting
https://bugs.webkit.org/show_bug.cgi?id=285911

Reviewed by Xabier Rodriguez-Calvar.

The logIdentifier() returns an uint64_t value but what we want is actually the objectIdentifier, the
same one used in Logger::LogSiteIdentifier::toString(). The latter can't be reused because it
generates a string with additional fields (method name and potentially class name).

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::GStreamerPeerConnectionBackend):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

Canonical link: https://commits.webkit.org/288921@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list