[webkit-changes] [WebKit/WebKit] 1c7bd4: 9x fast/events/iOS/* are flaky timeouts on EWS

[lilyspiniolas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c7bd44a4a92b266c8ae7f0c35bc33f9ab5862ba
      https://github.com/WebKit/WebKit/commit/1c7bd44a4a92b266c8ae7f0c35bc33f9ab5862ba
  Author: Lily Spiniolas <lily_spiniolas at apple.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control.html
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option.html
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift.html
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift.html
    M LayoutTests/fast/events/ios/keyboard-scrolling-distance.html
    M LayoutTests/fast/events/ios/keydown-keyup-arrow-keys-in-non-editable-element.html
    M LayoutTests/fast/events/ios/keydown-keyup-in-non-editable-content.html
    M LayoutTests/fast/events/ios/keydown-keyup-special-keys-in-non-editable-element.html
    M LayoutTests/fast/events/ios/tab-cycle.html
    M LayoutTests/platform/ios/TestExpectations

  Log Message:
  -----------
  9x fast/events/iOS/* are flaky timeouts on EWS
https://bugs.webkit.org/show_bug.cgi?id=279704
rdar://136982012

Reviewed by Abrar Rahman Protyasha and Tim Horton.

9 layout tests are currently failing on iOS since the tests rely on key events
being received without an editable-element focused. The failures were caused by
collisions with UIKit's usage of `+isInHardwareKeyboardMode` as discussed in
https://commits.webkit.org/283793@main, which prevented the WebKit content view
from receiving key events. Each of these tests have been updated to set test
option 'useHardwareKeyboardMode' to true so that `+isInHardwareKeyboardMode`
returns YES, allowing the content view to once again receive the key events for
these tests. The TestExpectations have been updated accordingly.

* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control.html:
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option.html:
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift.html:
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift.html:
* LayoutTests/fast/events/ios/keyboard-scrolling-distance.html:
* LayoutTests/fast/events/ios/keydown-keyup-arrow-keys-in-non-editable-element.html:
* LayoutTests/fast/events/ios/keydown-keyup-in-non-editable-content.html:
* LayoutTests/fast/events/ios/keydown-keyup-special-keys-in-non-editable-element.html:
* LayoutTests/fast/events/ios/tab-cycle.html:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/288917@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications