[webkit-changes] [WebKit/WebKit] 0f0fc1: LLInt/IPInt should check if BBQ is enabled before ...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f0fc14f86d4b6fa10d70f63a1949031345477bf
      https://github.com/WebKit/WebKit/commit/0f0fc14f86d4b6fa10d70f63a1949031345477bf
  Author: Daniel Liu <daniel_liu4 at apple.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp
    M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp

  Log Message:
  -----------
  LLInt/IPInt should check if BBQ is enabled before tiering SIMD functions to BBQ
https://bugs.webkit.org/show_bug.cgi?id=285919
rdar://142808201

Reviewed by Yijia Huang and Yusuke Suzuki.

Currently, LLInt and IPInt tier up SIMD functions immediately to BBQ. However, in
the Plan for these tiers, the only check is if `useWasmJIT()` is on. Thus, if BBQ
is disabled, but `useWasmJIT` is still enabled, we will hit an assertion failure
checking that BBQ is enabled.

* Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp:
(JSC::Wasm::IPIntPlan::compileFunction):
* Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::compileFunction):

Canonical link: https://commits.webkit.org/288900@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications