[webkit-changes] [WebKit/WebKit] 7c0c59: Null check ResourceLoader::frameLoader

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c0c598e2f0ef91b71910021927489198a3bb0b3
      https://github.com/WebKit/WebKit/commit/7c0c598e2f0ef91b71910021927489198a3bb0b3
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
    M Source/WebCore/loader/SubresourceLoader.cpp
    M Source/WebCore/loader/appcache/ApplicationCacheHost.cpp
    M Source/WebCore/loader/cache/CachedImage.cpp
    M Source/WebCore/loader/ios/LegacyPreviewLoader.mm
    M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp

  Log Message:
  -----------
  Null check ResourceLoader::frameLoader
https://bugs.webkit.org/show_bug.cgi?id=285924
rdar://142902036

Reviewed by Pascoe.

288750 at main introduced more cases where it can become null during teardown.
Internal bots are generating lots of crash logs in CachedImage::checkShouldPaintBrokenImage
but this should fix that and other places where the FrameLoader* was dereferenced
without checking if it's null.

* Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::didFinishLoading):
* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
* Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadSynchronously):
* Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::checkShouldPaintBrokenImage):
* Source/WebCore/loader/ios/LegacyPreviewLoader.mm:
(WebCore::makeClient):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):

Canonical link: https://commits.webkit.org/288888@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications