[webkit-changes] [WebKit/WebKit] 69dd10: Make UIScriptContext::asyncTaskComplete more robust

Alex Christensen noreply at github.com
Tue Jan 14 13:15:28 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69dd10c878eb1fa41cf048bf8f3ec62b1b50e9e5
      https://github.com/WebKit/WebKit/commit/69dd10c878eb1fa41cf048bf8f3ec62b1b50e9e5
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M Tools/TestRunnerShared/UIScriptContext/UIScriptContext.cpp

  Log Message:
  -----------
  Make UIScriptContext::asyncTaskComplete more robust
https://bugs.webkit.org/show_bug.cgi?id=285930
rdar://142903461

Reviewed by Pascoe.

I have crash logs that indicate that it can sometimes be called with a key of 0,
and it can sometimes be called with a key that returns a null callback, possibly
as state leftover from a previous test run that initiated an async task that was
not cancelled.  When this happens, ignore the call instead of crashing.

* Tools/TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::asyncTaskComplete):

Canonical link: https://commits.webkit.org/288886@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list