[webkit-changes] [WebKit/WebKit] 3b92ce: ASSERT SHOULD NEVER BE REACHED - WebCore::Layout::...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b92ce0658c9d24c53a91c47c631cc1fc6d201af
      https://github.com/WebKit/WebKit/commit/3b92ce0658c9d24c53a91c47c631cc1fc6d201af
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    A LayoutTests/fast/dynamic/partial-layout-with-spanning-inline-box-assert-expected.txt
    A LayoutTests/fast/dynamic/partial-layout-with-spanning-inline-box-assert.html
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h

  Log Message:
  -----------
  ASSERT SHOULD NEVER BE REACHED - WebCore::Layout::leadingInlineItemPositionOnLastLine
https://bugs.webkit.org/show_bug.cgi?id=285878

Reviewed by Antti Koivisto.

First/last layout box flag needs to be set on the entire content and not just on the newly created one.
It ensures the spanning inline boxes are handled correctly when the damaged line
starts with one.

* LayoutTests/fast/dynamic/partial-layout-with-spanning-inline-box-assert-expected.txt: Added.
* LayoutTests/fast/dynamic/partial-layout-with-spanning-inline-box-assert.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::handlePartialDisplayContentUpdate const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h:

Canonical link: https://commits.webkit.org/288870@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications